Skip to content

Remove and ban use of py.builtin#4658

Merged
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:py_deprecated_builtin
Jan 20, 2019
Merged

Remove and ban use of py.builtin#4658
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:py_deprecated_builtin

Conversation

@asottile

@asottile asottile commented Jan 20, 2019

Copy link
Copy Markdown
Member

No description provided.

RonnyPfannschmidt
RonnyPfannschmidt requested changes Jan 20, 2019
View reviewed changes
Comment thread src/_pytest/_code/source.py
@codecov

codecov Bot commented Jan 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4658 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4658      +/-   ##
==========================================
- Coverage   95.74%   95.73%   -0.01%     
==========================================
  Files         111      111              
  Lines       24795    24794       -1     
  Branches     2454     2454              
==========================================
- Hits        23739    23737       -2     
+ Misses        747      746       -1     
- Partials      309      311       +2
Flag Coverage Δ
#docs 29.51% <0%> (+0.07%) ⬆️
#doctesting 29.51% <0%> (+0.07%) ⬆️
#linting 29.51% <0%> (+0.07%) ⬆️
#linux 95.55% <83.33%> (-0.01%) ⬇️
#nobyte 92.33% <50%> (-0.02%) ⬇️
#numpy 93.15% <50%> (-0.01%) ⬇️
#pexpect 42.01% <16.66%> (ø) ⬆️
#py27 93.73% <50%> (-0.02%) ⬇️
#py34 91.85% <50%> (+0.06%) ⬆️
#py35 91.88% <50%> (+0.06%) ⬆️
#py36 91.89% <50%> (+0.06%) ⬆️
#py37 93.89% <50%> (+0.01%) ⬆️
#trial 93.15% <50%> (-0.01%) ⬇️
#windows 93.93% <83.33%> (-0.01%) ⬇️
#xdist 93.77% <83.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/assertion/rewrite.py 95.32% <ø> (ø) ⬆️
testing/python/collect.py 99.36% <ø> (ø) ⬆️
src/_pytest/_code/source.py 91.58% <100%> (+0.84%) ⬆️
testing/test_assertion.py 97.59% <80%> (ø) ⬆️
src/_pytest/cacheprovider.py 95.75% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bf9d6...ec5e279. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jan 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4658 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4658      +/-   ##
==========================================
- Coverage   95.74%   95.73%   -0.01%     
==========================================
  Files         111      111              
  Lines       24795    24794       -1     
  Branches     2454     2454              
==========================================
- Hits        23739    23737       -2     
+ Misses        747      746       -1     
- Partials      309      311       +2
Flag Coverage Δ
#docs 29.51% <0%> (+0.07%) ⬆️
#doctesting 29.51% <0%> (+0.07%) ⬆️
#linting 29.51% <0%> (+0.07%) ⬆️
#linux 95.55% <83.33%> (-0.01%) ⬇️
#nobyte 92.33% <50%> (-0.02%) ⬇️
#numpy 93.15% <50%> (-0.01%) ⬇️
#pexpect 42.01% <16.66%> (ø) ⬆️
#py27 93.73% <50%> (-0.02%) ⬇️
#py34 91.85% <50%> (+0.06%) ⬆️
#py35 91.88% <50%> (+0.06%) ⬆️
#py36 91.89% <50%> (+0.06%) ⬆️
#py37 93.89% <50%> (+0.01%) ⬆️
#trial 93.15% <50%> (-0.01%) ⬇️
#windows 93.93% <83.33%> (-0.01%) ⬇️
#xdist 93.77% <83.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/assertion/rewrite.py 95.32% <ø> (ø) ⬆️
testing/python/collect.py 99.36% <ø> (ø) ⬆️
src/_pytest/_code/source.py 91.58% <100%> (+0.84%) ⬆️
testing/test_assertion.py 97.59% <80%> (ø) ⬆️
src/_pytest/cacheprovider.py 95.75% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bf9d6...ec5e279. Read the comment docs.

@asottile asottile merged commit 653c685 into pytest-dev:master Jan 20, 2019
@asottile asottile deleted the py_deprecated_builtin branch January 20, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asottile @RonnyPfannschmidt