Skip to content

Fixes #4653 - tmp_path provides real path#4654

Merged
nicoddemus merged 1 commit into
pytest-dev:masterfrom
AuHau:fix/#4653-Fix_tmp_path_symlink_resolution
Jan 19, 2019
Merged

Fixes #4653 - tmp_path provides real path#4654
nicoddemus merged 1 commit into
pytest-dev:masterfrom
AuHau:fix/#4653-Fix_tmp_path_symlink_resolution

Conversation

@AuHau

@AuHau AuHau commented Jan 18, 2019

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jan 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4654 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4654      +/-   ##
==========================================
- Coverage   95.73%   95.72%   -0.02%     
==========================================
  Files         111      111              
  Lines       24783    24791       +8     
  Branches     2455     2455              
==========================================
+ Hits        23727    23732       +5     
  Misses        747      747              
- Partials      309      312       +3
Flag Coverage Δ
#docs 29.51% <11.11%> (+0.06%) ⬆️
#doctesting 29.51% <11.11%> (+0.06%) ⬆️
#linting 29.51% <11.11%> (+0.06%) ⬆️
#linux 95.55% <100%> (-0.02%) ⬇️
#nobyte 92.33% <100%> (ø) ⬆️
#numpy 93.15% <55.55%> (-0.02%) ⬇️
#pexpect 42% <11.11%> (-0.02%) ⬇️
#py27 93.73% <100%> (ø) ⬆️
#py34 91.85% <100%> (+0.06%) ⬆️
#py35 91.88% <100%> (+0.06%) ⬆️
#py36 91.89% <100%> (+0.06%) ⬆️
#py37 93.89% <100%> (-0.02%) ⬇️
#trial 93.15% <55.55%> (-0.02%) ⬇️
#windows 93.92% <100%> (ø) ⬆️
#xdist 93.76% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
testing/test_tmpdir.py 98.91% <100%> (+0.04%) ⬆️
src/_pytest/tmpdir.py 100% <100%> (ø) ⬆️
src/_pytest/cacheprovider.py 95.75% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6154a5a...04bd147. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jan 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4654 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4654      +/-   ##
==========================================
- Coverage   95.73%   95.72%   -0.02%     
==========================================
  Files         111      111              
  Lines       24783    24791       +8     
  Branches     2455     2455              
==========================================
+ Hits        23727    23732       +5     
  Misses        747      747              
- Partials      309      312       +3
Flag Coverage Δ
#docs 29.51% <11.11%> (+0.06%) ⬆️
#doctesting 29.51% <11.11%> (+0.06%) ⬆️
#linting 29.51% <11.11%> (+0.06%) ⬆️
#linux 95.55% <100%> (-0.02%) ⬇️
#nobyte 92.33% <100%> (ø) ⬆️
#numpy 93.15% <55.55%> (-0.02%) ⬇️
#pexpect 42% <11.11%> (-0.02%) ⬇️
#py27 93.73% <100%> (ø) ⬆️
#py34 91.85% <100%> (+0.06%) ⬆️
#py35 91.88% <100%> (+0.06%) ⬆️
#py36 91.89% <100%> (+0.06%) ⬆️
#py37 93.89% <100%> (-0.02%) ⬇️
#trial 93.15% <55.55%> (-0.02%) ⬇️
#windows 93.92% <100%> (ø) ⬆️
#xdist 93.76% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
testing/test_tmpdir.py 98.91% <100%> (+0.04%) ⬆️
src/_pytest/tmpdir.py 100% <100%> (ø) ⬆️
src/_pytest/cacheprovider.py 95.75% <0%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6154a5a...04bd147. Read the comment docs.

@Tadaboody Tadaboody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoddemus nicoddemus merged commit 57bf9d6 into pytest-dev:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants