Skip to content

Add docs page about plans for dropping py27 and py34#4646

Merged
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:2.7-deprecation-docs
Jan 16, 2019
Merged

Add docs page about plans for dropping py27 and py34#4646
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:2.7-deprecation-docs

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

Fix #4635

@nicoddemus nicoddemus force-pushed the 2.7-deprecation-docs branch from 866adbf to e2a9aaf Compare January 15, 2019 00:10
@codecov

codecov Bot commented Jan 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4646 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4646      +/-   ##
==========================================
+ Coverage   95.71%   95.73%   +0.02%     
==========================================
  Files         111      111              
  Lines       24761    24761              
  Branches     2454     2454              
==========================================
+ Hits        23701    23706       +5     
+ Misses        747      745       -2     
+ Partials      313      310       -3
Flag Coverage Δ
#docs 29.58% <ø> (+0.1%) ⬆️
#doctesting 29.58% <ø> (+0.1%) ⬆️
#linting 29.58% <ø> (+0.1%) ⬆️
#linux 95.55% <ø> (+0.02%) ⬆️
#nobyte 92.34% <ø> (ø) ⬆️
#numpy 93.15% <ø> (ø) ⬆️
#pexpect 42.04% <ø> (ø) ⬆️
#py27 93.74% <ø> (+0.02%) ⬆️
#py34 91.84% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.89% <ø> (+0.06%) ⬆️
#py37 93.89% <ø> (+0.02%) ⬆️
#trial 93.15% <ø> (ø) ⬆️
#windows 93.93% <ø> (ø) ⬆️
#xdist 93.76% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/cacheprovider.py 96.69% <0%> (ø) ⬆️
src/_pytest/terminal.py 91.76% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5903f45...e2a9aaf. Read the comment docs.

@nicoddemus

Copy link
Copy Markdown
Member Author

Hi @KengoTODA,

Shouldn't the rtd-bot post a link on this PR to the built documentation? 🤔

@KengoTODA

Copy link
Copy Markdown

@nicoddemus the HEAD of this PR comes from other repo, so RTD cannot build based on changes in this PR. So, to use rtd-bot, the HEAD of PR should exist in the same repo.

@nicoddemus

Copy link
Copy Markdown
Member Author

Ahh I figured as much, thanks. 👍


**After 2020**, the core team will no longer actively back port-patches, but the ``4.x-maintenance``
branch will continue to exist so the community itself can contribute patches. The
core team will be happy to accept those patches and make new ``4.X`` releases **until mid-2020**.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RonnyPfannschmidt I've added mid-2020 here just to have some end date. What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus the devil on my shoulder just wants to make the deprecation warning more and more passive aggressive with each release - as long s the release pipeline is accessible the effort to cut a release can be downsized to something nicely manageable

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem with the warnings, I wonder though if we want to declare a final date where we are no longer obligated to make 4.X releases anymore (even if we still do occasionally)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we have about 9 months of active support (2.7 gone form mainline vs 2.7 eol), i think having a 6 month grace period after that to do releases from our side is fine, afterwards its the end of line from our side, no more releases but we should still merge to the maintenance branch in good faith (people have to manage their setups on their own then)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

OK to merge this then?

@nicoddemus nicoddemus merged commit 6154a5a into pytest-dev:master Jan 16, 2019
@nicoddemus nicoddemus deleted the 2.7-deprecation-docs branch January 16, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants