Skip to content

Add rtd-bot configuration file#4642

Merged
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:rtd-bot-config
Jan 14, 2019
Merged

Add rtd-bot configuration file#4642
nicoddemus merged 1 commit into
pytest-dev:masterfrom
nicoddemus:rtd-bot-config

Conversation

@nicoddemus

Copy link
Copy Markdown
Member

Part of the configuration necessary for https://github.com/apps/rtd-helper

@rtd-helper

rtd-helper Bot commented Jan 13, 2019

Copy link
Copy Markdown

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

@rtd-helper

rtd-helper Bot commented Jan 13, 2019

Copy link
Copy Markdown

The rtd-bot is activated, but no .github/config.yml found in this repository.
Make sure that you have it in your default branch.

@codecov

codecov Bot commented Jan 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4642 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4642      +/-   ##
==========================================
+ Coverage   95.72%   95.74%   +0.02%     
==========================================
  Files         111      111              
  Lines       24761    24761              
  Branches     2454     2454              
==========================================
+ Hits        23702    23707       +5     
+ Misses        747      745       -2     
+ Partials      312      309       -3
Flag Coverage Δ
#docs 29.55% <ø> (+0.07%) ⬆️
#doctesting 29.55% <ø> (+0.07%) ⬆️
#linting 29.55% <ø> (+0.07%) ⬆️
#linux 95.56% <ø> (+0.02%) ⬆️
#nobyte 92.34% <ø> (+0.01%) ⬆️
#numpy 93.18% <ø> (+0.03%) ⬆️
#pexpect 42.06% <ø> (+0.02%) ⬆️
#py27 93.74% <ø> (+0.03%) ⬆️
#py34 91.84% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.89% <ø> (+0.06%) ⬆️
#py37 93.89% <ø> (ø) ⬆️
#trial 93.18% <ø> (+0.03%) ⬆️
#windows 93.93% <ø> (+0.01%) ⬆️
#xdist 93.73% <ø> (-0.05%) ⬇️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.76% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48f689...f2174c1. Read the comment docs.

@blueyed

blueyed commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

I do not like the following from https://github.com/KengoTODA/rtd-bot/ for security reasons:

Invite rtd-bot user to your RTD project as maintainer.

@blueyed

blueyed commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

Ah, that's for the RTD project, but still..

@nicoddemus

Copy link
Copy Markdown
Member Author

I think it is alright, tox has been using the same service too.

@KengoTODA

Copy link
Copy Markdown

Hi, thanks for your consideration regarding rtd-bot!

If it's necessary for security reason, you can deploy your bot by own. What you need is just a heroku dyno and a GitHub probot. :)

@blueyed

blueyed commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

I also think it is fine, especially since we do not have own infrastructure for this.

@nicoddemus nicoddemus merged commit 1bb463a into pytest-dev:master Jan 14, 2019
@nicoddemus nicoddemus deleted the rtd-bot-config branch January 14, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants