Skip to content

Mention PYTHONPATH semantics in goodpractices.rst#4626

Merged
asottile merged 1 commit into
pytest-dev:masterfrom
nicoddemus:goodpractices-pythonpath
Jan 10, 2019
Merged

Mention PYTHONPATH semantics in goodpractices.rst#4626
asottile merged 1 commit into
pytest-dev:masterfrom
nicoddemus:goodpractices-pythonpath

Conversation

@nicoddemus

@nicoddemus nicoddemus commented Jan 10, 2019

Copy link
Copy Markdown
Member

Fix #4625

@dogweather would appreciate your feedback as well. 👍

@dogweather

dogweather commented Jan 10, 2019

Copy link
Copy Markdown

Exactly! Thank you - I like the explicit mention of python -m pytest. I'm not experienced enough to comment on the rest, but I'm glad to see that here.

@codecov

codecov Bot commented Jan 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4626 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4626      +/-   ##
==========================================
+ Coverage   95.72%   95.75%   +0.02%     
==========================================
  Files         111      111              
  Lines       24683    24683              
  Branches     2446     2446              
==========================================
+ Hits        23629    23634       +5     
+ Misses        741      739       -2     
+ Partials      313      310       -3
Flag Coverage Δ
#docs 29.57% <ø> (+0.07%) ⬆️
#doctesting 29.57% <ø> (+0.07%) ⬆️
#linting 29.57% <ø> (+0.07%) ⬆️
#linux 95.57% <ø> (+0.02%) ⬆️
#nobyte 92.37% <ø> (ø) ⬆️
#numpy 93.19% <ø> (+0.02%) ⬆️
#pexpect 42.12% <ø> (+0.02%) ⬆️
#py27 93.78% <ø> (+0.02%) ⬆️
#py34 91.86% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.91% <ø> (+0.06%) ⬆️
#py37 93.93% <ø> (+0.02%) ⬆️
#trial 93.19% <ø> (+0.02%) ⬆️
#windows 93.93% <ø> (ø) ⬆️
#xdist 93.78% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.76% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ab5a7...9f6d9ef. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jan 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4626 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4626      +/-   ##
==========================================
+ Coverage   95.72%   95.75%   +0.02%     
==========================================
  Files         111      111              
  Lines       24683    24683              
  Branches     2446     2446              
==========================================
+ Hits        23629    23634       +5     
+ Misses        741      739       -2     
+ Partials      313      310       -3
Flag Coverage Δ
#docs 29.57% <ø> (+0.07%) ⬆️
#doctesting 29.57% <ø> (+0.07%) ⬆️
#linting 29.57% <ø> (+0.07%) ⬆️
#linux 95.57% <ø> (+0.02%) ⬆️
#nobyte 92.37% <ø> (ø) ⬆️
#numpy 93.19% <ø> (+0.02%) ⬆️
#pexpect 42.12% <ø> (+0.02%) ⬆️
#py27 93.78% <ø> (+0.02%) ⬆️
#py34 91.86% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.91% <ø> (+0.06%) ⬆️
#py37 93.93% <ø> (+0.02%) ⬆️
#trial 93.19% <ø> (+0.02%) ⬆️
#windows 93.93% <ø> (ø) ⬆️
#xdist 93.78% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/terminal.py 91.76% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ab5a7...9f6d9ef. Read the comment docs.

asottile
asottile approved these changes Jan 10, 2019
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest, I saw PYTHONPATH on the title and panicked, this is great though thanks for adding this!

@asottile asottile merged commit bace285 into pytest-dev:master Jan 10, 2019
@nicoddemus nicoddemus deleted the goodpractices-pythonpath branch January 10, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @dogweather @asottile