Fix assertion rewriting involving Starred + side-effects#4414
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4414 +/- ##
==========================================
+ Coverage 95.89% 95.92% +0.02%
==========================================
Files 111 111
Lines 25002 25006 +4
Branches 2438 2438
==========================================
+ Hits 23975 23986 +11
+ Misses 726 723 -3
+ Partials 301 297 -4
Continue to review full report at Codecov.
|
blueyed
approved these changes
Nov 17, 2018
Member
|
@asottile great job, that one must have been very puzzling to find, the original "wrong" code looks so "right" |
Member
Author
|
<3 I've spent way more than my fair share staring at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4412