Add Testdir.__str__ to return str(self.tmpdir)#4409
Merged
Conversation
I just expected this with `monkeypatch.setenv("PYTHONPATH", str(testdir))`,
wondering why it was not picked up correctly.
`
Member
|
im on the fence on this one - i'd really like to treat this one as only a path if the fspath protocol is followed at best |
Contributor
Author
|
It's not really treated as a path by this, but there is no point in |
RonnyPfannschmidt
approved these changes
Nov 18, 2018
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
as long as we actually call it testdir its probably ok to do
as a follow-up we might want to consider something with a more strict name and stricter boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just expected this with
monkeypatch.setenv("PYTHONPATH", str(testdir)),wondering why it was not picked up correctly.