Don't string-compare version numbers#4308
Merged
asottile merged 1 commit intoNov 5, 2018
Merged
Conversation
Member
Author
|
the py37 job seems pretty sad for this change :S it passes locally however: |
RonnyPfannschmidt
approved these changes
Nov 5, 2018
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
failure is unrelated, i'd prefer if we used or followed up with or used either a recent setuptools version parse or a packaging version parse
Contributor
Please create an issue then. Altogether I would have liked to see a regression test for this also. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4306