Hahaha thanks for the lightning quick fix @asottile! 🙇

personally i appreciate having someone that's not me dedicated to the pain of yaml ^^

@RonnyPfannschmidt I feel ya, yaml is my biggest regret w/ pre-commit

yaml is my biggest regret w/ pre-commit

Oh really? I'm curious why you feel that way. Also, which alternatives would you use instead of yaml for pre-commit configuration?

yaml is my biggest regret w/ pre-commit

Oh really? I'm curious why you feel that way. Also, which alternatives would you use instead of yaml for pre-commit configuration?

The biggest being that it can't be programmatically rewritten. autoupdate (though glorious) is a giant hack -- it used to be one of the biggest sources of frustration.

There's also the sheer complexity (and slowness) of yaml -- the spec for json fits on a postcard, but yaml's is 84 pages. The default implementation of yaml has some famous security problems and unless you've got libyaml-dev at install time (and the appropriate code to opt into the fast path, you're stuck in the pure-python slow path. Even the fast path is orders of magnitude slower than the equivalent json calls.

To be honest, I haven't found a better alternative. What I really want is some high level configuration that's fast, readable, and machine rewritable. json5 seems so close to what I want, but the parsers for python are an awful pile of pure python + regex and aren't round trippable. I even tried to invent my own config language and while it worked, it wasn't ever really production worthy (a fun exercise though, I learned a ton and wrote some cool toys).

Maybe one day I'll have enough time to make json5 functional in python... but until then I'll continue shouting to the wind 😭

Codecov Report

Merging #4281 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
- Coverage   95.87%   95.65%   -0.23%     
==========================================
  Files         109      109              
  Lines       24630    24630              
  Branches     2396     2396              
==========================================
- Hits        23615    23560      -55     
- Misses        720      759      +39     
- Partials      295      311      +16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fea71a...af00367. Read the comment docs.

Thanks for the detailed write up!

And what about toml?

Also doesn't have a round-trip parser :(

Hmm.

About the roundtrip parser, conda uses ruamel.yaml. 👍

Yeah, I tried it it didn't quite cut it. Kinda funny though, from their overview page:

flow style sequences ( ‘a: b, c, d’) (based on request and test by Anthony Sottile)