Skip to content

Spelling and grammar fixes#4264

Merged
nicoddemus merged 2 commits into
pytest-dev:masterfrom
scop:spelling2
Oct 30, 2018
Merged

Spelling and grammar fixes#4264
nicoddemus merged 2 commits into
pytest-dev:masterfrom
scop:spelling2

Conversation

@scop

@scop scop commented Oct 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 30, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4264 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4264      +/-   ##
==========================================
- Coverage   95.87%   95.86%   -0.01%     
==========================================
  Files         109      109              
  Lines       24606    24608       +2     
  Branches     2394     2394              
==========================================
  Hits        23591    23591              
- Misses        720      721       +1     
- Partials      295      296       +1
Flag Coverage Δ
#docs 29.04% <0%> (ø) ⬆️
#doctesting 29.04% <0%> (ø) ⬆️
#linting 29.04% <0%> (ø) ⬆️
#linux 95.65% <0%> (-0.01%) ⬇️
#nobyte 92.02% <0%> (ø) ⬆️
#numpy 93.01% <0%> (ø) ⬆️
#pexpect 41.66% <0%> (ø) ⬆️
#py27 94.05% <0%> (ø) ⬆️
#py34 92.34% <0%> (+0.03%) ⬆️
#py35 92.35% <0%> (+0.03%) ⬆️
#py36 93.99% <0%> (-0.01%) ⬇️
#py37 92.37% <0%> (+0.03%) ⬆️
#trial 93.01% <0%> (ø) ⬆️
#windows 94.13% <0%> (-0.01%) ⬇️
#xdist 93.89% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/_pytest/config/argparsing.py 88.15% <ø> (ø) ⬆️
src/_pytest/hookspec.py 100% <ø> (ø) ⬆️
src/_pytest/capture.py 93.39% <ø> (-0.46%) ⬇️
src/_pytest/python.py 95.84% <ø> (ø) ⬆️
src/_pytest/fixtures.py 97.37% <ø> (ø) ⬆️
src/_pytest/mark/structures.py 94.64% <ø> (ø) ⬆️
src/_pytest/pathlib.py 89.26% <0%> (ø) ⬆️
src/_pytest/_code/source.py 90.74% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e40db...a035c89. Read the comment docs.

blueyed
blueyed approved these changes Oct 30, 2018
View reviewed changes

@blueyed blueyed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

asottile
asottile approved these changes Oct 30, 2018
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! how did you find these?

Comment thread src/_pytest/pathlib.py Outdated

its full of race conditions that are reasonably ok to ignore
it's full of race conditions that are reasonably ok to ignore
for the contex of best effort linking to the latest testrun

@asottile asottile Oct 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context ;)

@scop

scop commented Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Don't remember in particular, but usually it's some homegrown greps, https://github.com/client9/misspell etc

@RonnyPfannschmidt

RonnyPfannschmidt commented Oct 30, 2018

Copy link
Copy Markdown
Member

@asottile that one looks like an nice potential addition as a pre-commit hook ^^

@nicoddemus

nicoddemus commented Oct 30, 2018

Copy link
Copy Markdown
Member

Weird, can anyone explain why codecov is saying that the coverage has decreased, when clearly that's not the case? 🤔

@nicoddemus nicoddemus merged commit 46ec0ec into pytest-dev:master Oct 30, 2018
@blueyed

blueyed commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

why codecov is saying that the coverage has decreased, when clearly that's not the case?

I think codecov is still buggy / having problems with the pytest repo in general.
But here it might be a general bug/issue, maybe because of touching doc strings only, which might be considered as not being covered and then it gets it wrong etc, but really do not know.

@nicoddemus

nicoddemus commented Oct 30, 2018

Copy link
Copy Markdown
Member

😞

@blueyed

blueyed commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

Sometimes it also confuses the base commit - i.e. Travis gets run on the merge commit, but then it is compared to master or something like that.

@scop scop deleted the spelling2 branch October 30, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@asottile asottile asottile approved these changes

+1 more reviewer

@blueyed blueyed blueyed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scop @RonnyPfannschmidt @nicoddemus @blueyed @asottile