pdb: handle quitting in post_mortem#4133
Merged
Merged
Conversation
nicoddemus
previously requested changes
Oct 13, 2018
nicoddemus
left a comment
Member
There was a problem hiding this comment.
Thanks! We also need a test and a CHANGELOG entry. 👍
Contributor
Author
|
py3 displays it as "_pytest.outcomes.Exit: Quitting debugger", while py2 uses |
Member
|
I think so, we can improve this later if need be |
Contributor
Author
|
I need to touch it anyway again, so might as well add a That's likely not it though, so will just adjust/losen the test in this regard. |
Member
|
Sounds good, thanks! |
`help quit` in pdb says: > Quit from the debugger. The program being executed is aborted. But pytest would continue with the next tests, often making it necessary to kill the pytest process when using `--pdb` and trying to cancel the tests using `KeyboardInterrupt` / `Ctrl-C`.
nicoddemus
approved these changes
Oct 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
help quitin pdb says:But pytest would continue with the next tests, often making it necessary
to kill the pytest process when using
--pdband trying to cancel thetests using
KeyboardInterrupt/Ctrl-C.TODO: