Improve tracebacks for ImportErrors in conftest#4124
Merged
nicoddemus merged 4 commits intopytest-dev:featuresfrom Oct 13, 2018
Merged
Improve tracebacks for ImportErrors in conftest#4124nicoddemus merged 4 commits intopytest-dev:featuresfrom
nicoddemus merged 4 commits intopytest-dev:featuresfrom
Conversation
blueyed
approved these changes
Oct 12, 2018
| # points to dynamically generated code | ||
| # see https://bitbucket.org/pytest-dev/py/issues/71 | ||
| raw_filename = entry.frame.code.raw.co_filename | ||
| is_generated = "<" in raw_filename and ">" in raw_filename |
Contributor
There was a problem hiding this comment.
<> would be a valid filename, no? Similar to foo><bar - so maybe use startswith/endswith at least?
Contributor
There was a problem hiding this comment.
I see that it is just moved code though.
Member
Author
There was a problem hiding this comment.
Makes sense, but I'm not sure I would like to touch that now, there might be some corner case which is covered by that, plus <> are not valid characters for filenames AFAIK so I think we're safe. 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an conftest import error on master:
and here's the same error on this branch:
Fix #3332
cc @The-Compiler
Thanks @feuillemorte for the initial take on this in #3345 👍