Skip to content

Fix #3539: reload module with assertion rewrite import hook#4022

Merged
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
iwanb:fix_reload
Sep 23, 2018
Merged

Fix #3539: reload module with assertion rewrite import hook#4022
RonnyPfannschmidt merged 1 commit into
pytest-dev:masterfrom
iwanb:fix_reload

Conversation

@iwanb

@iwanb iwanb commented Sep 23, 2018

Copy link
Copy Markdown
Contributor

The current reload hook did not reload code of already imported modules.
See https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module

Fix #3539

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 93.811% when pulling c61ff31 on iwanb:fix_reload into ec57cbf on pytest-dev:master.

@nicoddemus nicoddemus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

@RonnyPfannschmidt RonnyPfannschmidt merged commit eca3e78 into pytest-dev:master Sep 23, 2018
@RonnyPfannschmidt

Copy link
Copy Markdown
Member

fabulous 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants