Skip to content

Update release procedure#3909

Merged
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:update_release
Aug 29, 2018
Merged

Update release procedure#3909
asottile merged 1 commit into
pytest-dev:masterfrom
asottile:update_release

Conversation

@asottile

Copy link
Copy Markdown
Member

No description provided.

@asottile asottile requested review from blueyed and nicoddemus August 29, 2018 21:14

@blueyed blueyed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good/better.

What about using GitHub's releases (https://github.com/pytest-dev/pytest/releases) directly though?
I.e. just tag the release via GitHub (on master), which also triggers a build then already.

@nicoddemus

Copy link
Copy Markdown
Member

just tag the release via GitHub (on master), which also triggers a build then already.

This is fine, but I would prefer to tag exactly the same commit that was approved on the PR. If this is possible to do via GitHub's UI, then great!

@blueyed

blueyed commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

This is fine, but I would prefer to tag exactly the same commit that was approved on the PR. If this is possible to do via GitHub's UI, then great!

Sure.. you can specify a commit, and/or browse them via "recent commits" on https://github.com/pytest-dev/pytest/releases/new.

Maybe we should update the document according to this instead?
Or wait for the next iteration/release?

@asottile asottile merged commit f1bd462 into pytest-dev:master Aug 29, 2018
@asottile asottile deleted the update_release branch August 29, 2018 21:37
@blueyed

blueyed commented Aug 29, 2018

Copy link
Copy Markdown
Contributor

Might be good to have some script to fill in the release notes then also (copy'n'paste via some towncrier output/command).

@nicoddemus

nicoddemus commented Aug 29, 2018

Copy link
Copy Markdown
Member

Maybe we should update the document according to this instead?

We can add it as an alternative, sure.

Might be good to have some script to fill in the release notes then also (copy'n'paste via some towncrier output/command).

The release notes are generated from tox -e release 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants