Travis: use TOXENV=linting for linting stage#3874
Merged
Merged
Conversation
This will run it with `--show-diff-on-failure` then, and helps to keep it in line / in a central place.
asottile
approved these changes
Aug 25, 2018
asottile
left a comment
Member
There was a problem hiding this comment.
Change seems fine 👍
I wonder if this was done to avoid tox overhead though -- but that's, what, a few seconds?
Member
|
oh actually, maybe add |
nicoddemus
approved these changes
Aug 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will run it with
--show-diff-on-failurethen, and helps to keepit in line / in a central place.
See https://travis-ci.org/pytest-dev/pytest/jobs/420595379 for an example failure.
Appveyor uses TOXENV=linting already.