Skip to content

Support xfailed and xpassed outcomes in RunResult.#3838

Merged
nicoddemus merged 1 commit into
pytest-dev:featuresfrom
wimglenn:runresult_xfail
Aug 20, 2018
Merged

Support xfailed and xpassed outcomes in RunResult.#3838
nicoddemus merged 1 commit into
pytest-dev:featuresfrom
wimglenn:runresult_xfail

Conversation

@wimglenn

@wimglenn wimglenn commented Aug 20, 2018

Copy link
Copy Markdown
Member

Added support for xfailed and xpassed outcomes to the pytester.RunResult.assert_outcomes signature.

closes #3837

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

the linting failed, please use pre-commit to have our specific version of black sort out the code formatting

@wimglenn

Copy link
Copy Markdown
Member Author

Yeah, my bad, I disabled it because the pre-commit hardcodes Python 3.6 but I only have 2.7 and 3.7 installed. Will fix manually..

@wimglenn

Copy link
Copy Markdown
Member Author

@RonnyPfannschmidt rebased and linted

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

@asottile im wondering, can pre-commit be taught to use something more controllable there?

@asottile

Copy link
Copy Markdown
Member

Upstream switched to just language_version: python3 🤷

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 92.598% when pulling 539a22c on wimglenn:runresult_xfail into 28aff05 on pytest-dev:master.

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

@asottile good point, what should pytest do, just the same?

@nicoddemus

Copy link
Copy Markdown
Member

This should target features given it adds new capabilities to pytester, right?

(I want to take a good look at the code later, please don't merge yet 😁)

@wimglenn wimglenn changed the base branch from master to features August 20, 2018 14:43
@wimglenn

Copy link
Copy Markdown
Member Author

@nicoddemus Yes, I guess you're right - I've just switched the base branch.
Trying not to head-explode about how meta it is (tests for the tester for pytest and they run using pytester itself..) 🤕

@nicoddemus

nicoddemus commented Aug 20, 2018

Copy link
Copy Markdown
Member

Trying not to head-explode about how meta it is (tests for the tester for pytest and they run using pytester itself..)

Heh! 😁

@nicoddemus

Copy link
Copy Markdown
Member

Thanks @wimglenn!

@nicoddemus nicoddemus merged commit 044d2b8 into pytest-dev:features Aug 20, 2018
@wimglenn wimglenn deleted the runresult_xfail branch August 20, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants