Skip to content

Fix Capfd From Fixtures After Test Teardown#3066

Closed
trrichard wants to merge 2 commits into
pytest-dev:masterfrom
trrichard:master
Closed

Fix Capfd From Fixtures After Test Teardown#3066
trrichard wants to merge 2 commits into
pytest-dev:masterfrom
trrichard:master

Conversation

@trrichard

Copy link
Copy Markdown

Resolves #3033

@nicoddemus

@nicoddemus

Copy link
Copy Markdown
Member

Hi @trrichard, sorry for the delay.

Unfortunately this causes the tests which ensure capsys and capfd can be used for other fixtures to break, so I'm not sure this will be enough...

@trrichard

Copy link
Copy Markdown
Author

Hummm. Well I'm not sure I know how to fix it then.

Could you take a look?

@nicoddemus nicoddemus self-assigned this Jan 10, 2018
@nicoddemus

Copy link
Copy Markdown
Member

@trrichard will do, thanks!

@RonnyPfannschmidt

Copy link
Copy Markdown
Member

@nicoddemus ping?

@nicoddemus

nicoddemus commented Jun 27, 2018

Copy link
Copy Markdown
Member

Thanks for the ping @RonnyPfannschmidt; this is on my radar, I will definitely get back to it when I get a chance.

@nicoddemus

Copy link
Copy Markdown
Member

Sorry again for the delay @trrichard.

I opened #3830 instead of pushing to this one because I had to rebase on master and did not want to force-push to your fork.

@nicoddemus nicoddemus closed this Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants