fix #6881 - add policies for too long ids from a str and use short as default#13370
Draft
RonnyPfannschmidt wants to merge 1 commit intopytest-dev:mainfrom
Draft
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/_pytest/python.py:114
- Typo 'parameer' should be 'parameter', and the help text mentions 'sha3' while the code uses hashlib.sha256. Please update for consistency.
help="strategy for parameer values that result in long ids\n- short: default: shorten the value normally\n- hash: take a sha3 of the value for content matching ids\n- legacy: keep the long id (only use this for temporary backward compatibility)\n- disallow: fail and request explicit ids",
testing/python/metafunc.py:666
- [nitpick] The expected output for the 'short' strategy ('a0') when the input string is long is non-obvious. Please add a comment to clarify the rationale for this expected value.
"short": "a0",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this experiments with addign a policy and a new default
closes #6881