Fix parametrized mark over staticmethod decorator#13022
Merged
bluetech merged 5 commits intopytest-dev:mainfrom Dec 14, 2024
eitanwass:bugfix/parametrize-over-staticmethod
Merged
Fix parametrized mark over staticmethod decorator#13022bluetech merged 5 commits intopytest-dev:mainfrom eitanwass:bugfix/parametrize-over-staticmethod
bluetech merged 5 commits intopytest-dev:mainfrom
eitanwass:bugfix/parametrize-over-staticmethod
Conversation
4 tasks
bluetech
reviewed
Dec 5, 2024
Member
bluetech
left a comment
There was a problem hiding this comment.
Thanks for tackling this @eitanwass! I left a couple of suggestions/questions.
bluetech
reviewed
Dec 5, 2024
Member
|
Hmph, should have squashed... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed parametrized markers over staticmethod and classmethod decorators.
closes #12863
An interesting thing about this solution and python (<3.9 vs 3.10<) compatibility:
In python3.10, they changed
@staticmethodand@classmethoddecorators to inherit method attributes.Before that version, functions wrapped with them did not return true for
callable()func, so it failed tests for py39 and succeeded for py310.link to changelog
For example: