Clarify pytest_ignore_collect docs #12385
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
approved these changes
May 28, 2024
Member
bluetech
left a comment
There was a problem hiding this comment.
I understand why you wrote it the way you did, but "consider this path to be considered for collection" sounded a bit clumsy to me... I put a suggestion to lean solely on the "ignore" terminology. But either way is OK by me.
Co-authored-by: Ran Benita <ran@unusedvar.com>
Member
Author
Oh no I appreciate very much the suggestions -- I could not give this too much thought TBH, wanted to get the ball rolling and hoped a good review would improve my initial wording. So success! Hehehe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12383