Skip to content

Fix MonkeyPatch.context#12375

Closed
harupy wants to merge 2 commits intopytest-dev:mainfrom
harupy:fix-mokeypatch-context
Closed

Fix MonkeyPatch.context#12375
harupy wants to merge 2 commits intopytest-dev:mainfrom
harupy:fix-mokeypatch-context

Conversation

@harupy
Copy link

@harupy harupy commented May 27, 2024

@harupy
Copy link
Author

harupy commented May 27, 2024

It looks like pre-commit reverted my change

@Pierre-Sassoulas
Copy link
Member

It seems due to something in ruff / pydocstyle, Do you care to investigate (You need to remove the --fix option to see what message is causing problem). There's a chance it introduced this issue in more place than just this file.

@harupy
Copy link
Author

harupy commented May 27, 2024

@Pierre-Sassoulas
Copy link
Member

You can revert 53e9aa4 and disable D412 to be sure, here:

pytest/pyproject.toml

Lines 135 to 136 in 24abe4e

"D404", # First word of the docstring should not be "This"
"D415", # First line should end with a period, question mark, or exclamation point

Reverting the problems introduced without tracking them all, could get technical. I guess reverting and reapplying then squashing could work. Let me know if I should take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants