Skip to content

python,unittest: don't collect abstract classes#12318

Merged
bluetech merged 1 commit intopytest-dev:mainfrom
bluetech:unittest-abc
May 13, 2024
Merged

python,unittest: don't collect abstract classes#12318
bluetech merged 1 commit intopytest-dev:mainfrom
bluetech:unittest-abc

Conversation

@bluetech
Copy link
Copy Markdown
Member

Fix #12275.

@bluetech
Copy link
Copy Markdown
Member Author

Thanks for the review @RonnyPfannschmidt.

Something seems wrong with the Codecov coverage notes on the PR diff, it seems to consider every new line as uncovered even though it definitely is. I may look into it later.

I've considered backporting this change, but decided against it since it might lead to more regressions that I can't think of. Instead I think we can release 8.3 somewhat soon (I do have some more regressions to look into...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v8.2.0 raises Can't instantiate abstract class when a test class implements an abstract class

2 participants