Fixes crashing under a squashfuse_ll read-only mount#12301
Merged
nicoddemus merged 4 commits intopytest-dev:mainfrom May 9, 2024
hotpxl:main
Merged
Fixes crashing under a squashfuse_ll read-only mount#12301nicoddemus merged 4 commits intopytest-dev:mainfrom hotpxl:main
nicoddemus merged 4 commits intopytest-dev:mainfrom
hotpxl:main
Conversation
nicoddemus
requested changes
May 9, 2024
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Looks good!
Can you please also update test_try_makedirs for this case? Thanks!
nicoddemus
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #12300 , pytest crashes with
OSError: [Errno 38] Function not implementedwhen it's run under a squashfuse_ll mountpoint. the exception comes from withinthis is because squashfuse_ll returns
ENOSYSinstead ofEROFSfor a read-only filesystem, which pytest doesn't know how to handle. This change adds handling of the error code.closes #12300