Accept None in _XfailMarkDecorator's conditionparam and expose default value#11565
Closed
Avasam wants to merge 2 commits intopytest-dev:mainfrom
Avasam:pytest.mark.xfail.condition
Closed
Accept None in _XfailMarkDecorator's conditionparam and expose default value#11565Avasam wants to merge 2 commits intopytest-dev:mainfrom Avasam:pytest.mark.xfail.condition
None in _XfailMarkDecorator's conditionparam and expose default value#11565Avasam wants to merge 2 commits intopytest-dev:mainfrom
Avasam:pytest.mark.xfail.condition
Conversation
2 tasks
for more information, see https://pre-commit.ci
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
I'm very torn on allowing this,
My personal preference is not to allow none there
Contributor
Author
|
If not, then the documentation for |
Member
|
I agree we should probably just update the docs: the docs used Thanks @Avasam I'm closing this then, would appreciate if you followed up with another PR just to update the docs. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here is a quick checklist that should be present in PRs.
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Fixes comments pypa/setuptools#3979 (comment) and #10094 (comment)
Should not conflict with #11501
Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
..Add yourself to
AUTHORSin alphabetical order.