Fix checking expected warnings when an exception is raised#10208
Closed
eltimen wants to merge 1 commit intopytest-dev:mainfrom
eltimen:fix-9036
Closed
Fix checking expected warnings when an exception is raised#10208eltimen wants to merge 1 commit intopytest-dev:mainfrom eltimen:fix-9036
eltimen wants to merge 1 commit intopytest-dev:mainfrom
eltimen:fix-9036
Conversation
pytest.warn and similar functions should capture warnings when an exception is raised inside a with block
RonnyPfannschmidt
requested changes
Aug 12, 2022
Member
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
This is a breaking change to intended behaviour,
Else the other exception gets hidden
Author
|
Hello @RonnyPfannschmidt. Could you please clarify what you mean by "other exception gets hidden" (with a minimal example, if possible)? |
Member
|
If the code that should warn |
Member
|
@RonnyPfannschmidt I think we should replace the existing error with a Can't re-open this when the upstream repo has been deleted, but I'll open a new one soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9036
The behavior in the issue is observed because
pytest.warndon't capture warnings when an exception is raised inside awithblock due to the condition inWarningsChecker.__exit__.It looks like removing this condition should fix this bug, Or is it needed to cover some case?