-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
good first issueeasy issue that is friendly to new contributoreasy issue that is friendly to new contributortopic: marksrelated to marks, either the general marks or builtinrelated to marks, either the general marks or builtintype: bugproblem that needs to be addressedproblem that needs to be addressed
Description
pytest versions: 5.4.x, current master
When @pytest.mark.skip/skipif marks are used to skip a test, for example
import pytest
@pytest.mark.skip
def test_skip_location() -> None:
assert 0the expected skip location reported should point to the item itself, and this is indeed what happens when running with pytest -rs:
SKIPPED [1] test_it.py:3: unconditional skip
However, adding pytest -rs --runxfail breaks this:
SKIPPED [1] src/_pytest/skipping.py:238: unconditional skip
The --runxfail is only about xfail and should not affect this at all.
Hint: the bug is in src/_pytest/skipping.py, the pytest_runtest_makereport hook.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueeasy issue that is friendly to new contributoreasy issue that is friendly to new contributortopic: marksrelated to marks, either the general marks or builtinrelated to marks, either the general marks or builtintype: bugproblem that needs to be addressedproblem that needs to be addressed