-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
pytester: run: use (global) MultiCapture with fds? #4937
Copy link
Copy link
Closed
Labels
plugin: capturerelated to the capture builtin pluginrelated to the capture builtin pluginplugin: debuggingrelated to the debugging builtin pluginrelated to the debugging builtin plugintype: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Metadata
Metadata
Assignees
Labels
plugin: capturerelated to the capture builtin pluginrelated to the capture builtin pluginplugin: debuggingrelated to the debugging builtin pluginrelated to the debugging builtin plugintype: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Type
Fields
Give feedbackNo fields configured for issues without a type.
I've made
testdir.runpytest_subprocesswork withpdb.set_trace(), but it currently requires to setstdin=None(instead of a new default (CLOSE_STDIN)), and use-s.I think the latter could be solved by using
MultiCapturealso forrunpytest_subprocess, and useMultiCapture(Capture=FDCapture)also forrunpytest_inprocess(it usesSysCapturecurrently).Then those would also need to be handled/managed by the the capmanager plugin, and this would likely allow pytest's
set_traceto suspend capturing then also.Thoughts?