Skip to content

Remove Python 2 support#274

Merged
goodboy merged 3 commits into
pytest-dev:masterfrom
bluetech:rm-python2
Jun 10, 2020
Merged

Remove Python 2 support#274
goodboy merged 3 commits into
pytest-dev:masterfrom
bluetech:rm-python2

Conversation

@bluetech

@bluetech bluetech commented Jun 6, 2020

Copy link
Copy Markdown
Member

For pluggy 1.0.

Fixes #272.

@goodboy goodboy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, I'm starting to get a little excited 😸

@bluetech bluetech force-pushed the rm-python2 branch 2 times, most recently from f4cfca8 to 1093ad6 Compare June 6, 2020 22:34
@bluetech

bluetech commented Jun 6, 2020

Copy link
Copy Markdown
Member Author

There was a if hasattr(inspect, "signature"): check that I had missed before, removed now.

@goodboy

goodboy commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

@bluetech also needs rebase. Sorry I must have merged in the non-ideal order.

@bluetech

bluetech commented Jun 7, 2020

Copy link
Copy Markdown
Member Author

also needs rebase.

Rebased.

Sorry I must have merged in the non-ideal order.

No problem, everything conflicts with everything and I intentionally submit based on current master. Just merge in whatever order and I'll rebase as necessary :)

@goodboy

goodboy commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Gah. I did it again.

Accidentally added in root directory in
673ab43.
@bluetech

bluetech commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

Rebased. I also noticed I accidentally added a changelog file in a previous PR to the root instead of changelog/, so just added another commit to fix that here (doesn't seem worth another PR).

Comment thread setup.py
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@goodboy goodboy merged commit 8bb166a into pytest-dev:master Jun 10, 2020
@bluetech bluetech deleted the rm-python2 branch June 28, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for Python 2

4 participants