[RFC] multicall: hookwrapper: use yielded results, support firstresult=True#246
Closed
blueyed wants to merge 4 commits intopytest-dev:masterfrom
Closed
[RFC] multicall: hookwrapper: use yielded results, support firstresult=True#246blueyed wants to merge 4 commits intopytest-dev:masterfrom
blueyed wants to merge 4 commits intopytest-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 92.91% 92.21% -0.71%
==========================================
Files 14 14
Lines 1651 1541 -110
Branches 115 116 +1
==========================================
- Hits 1534 1421 -113
- Misses 101 102 +1
- Partials 16 18 +2
Continue to review full report at Codecov.
|
Member
|
this should get a new name as its a new flow control
|
Contributor
Author
|
Yeah, ok. Not planning to do this anytime soon - closing. I've used two subplugins with pytest-dev/pytest#6448 now. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: pytest-dev/pytest#5301 (comment)
Currently results from a hookwrapper are ignored, this changes the behavior (see
test_hookwrapper_order).Should this be explicitly enabled, e.g. via a new "use_hookwrapper_result" kwarg for the hookwrapper? As the existing test shows "yield" might be used with a result, which currently is ignored.
A hookwrapper currently can set the return value / outcome via
force_result, but it would still run non-hookwrappers before.