Specify encoding in fdopen.#196
Merged
nicoddemus merged 3 commits intopytest-dev:masterfrom Jul 4, 2023
Merged
Conversation
Contributor
Author
|
This change doesn't fix but reveals many more EncodingWarnings in tests (but no more in the library). |
Member
|
Thanks @jaraco! We can live with the warnings in the tests for now. 👍 |
25ecd39 to
e2e0852
Compare
nicoddemus
approved these changes
Jul 4, 2023
Member
|
🎉 I was just trying to enable ...do we have release plans though? It's been two years, but v1.9.0...master is a lot of bugfixes to keep off PyPI. I'm just going to install from the commit, but it'd be nice to share more widely. |
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195