Restyle examples and add button to show code on all examples#968
Merged
Conversation
antocuni
approved these changes
Nov 21, 2022
antocuni
left a comment
Contributor
There was a problem hiding this comment.
wow, I love it 😍
I didn't do a proper review because I'm not well versed enough in HTML/CSS to do a meaningful review, but I'm approving it in case you want to proceed with the merge.
If you like to have a "proper" review, please ask someone (not me 😅)
Contributor
Author
|
Thank you, just pushed a small tweak to css to make the button work on small screens 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restyles the examples to match pyscript.net, this is how the main page looks like:
It also adds a section and a button that allows users to click and see the code in use
In order to get this working I had to do the following:
Finally, I stole the navbar from Kmeans and other examples and reused on each example 😄
There's a lot of examples that aren't included in the example page (should they?) so I haven't styled them