Allow pyscript package to contain multiple files#1309
Merged
Conversation
1ffc382 to
c884424
Compare
Followup to pyscript#1232. Closes pyscript#1226. Use node to make a manifest of the src/python dir and then use an esbuild plugin to resolve an import called `pyscript_python_package.esbuild_injected.json` to an object indicating the directories and files in the package folder. This object is then used to govern runtime installation of the package.
Contributor
Author
|
@WebReflection @antocuni would appreciate if you could review this one. |
Contributor
|
I'm confused. This PR adds the ability of having multiple files in |
Contributor
Author
|
Yes. My thought was to split up |
antocuni
approved these changes
Mar 29, 2023
antocuni
left a comment
Contributor
There was a problem hiding this comment.
ok, got it.
Technically speaking, this PR lacks a test because we don't know whether a package with multiple files actually works, but I'm fine waiting until the follow up PR to discover :)
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1232. Closes #1226.
Use node to make a manifest of the src/python dir and then use an esbuild plugin to resolve an import called
pyscript_python_package.esbuild_injected.jsonto an object indicating the directories and files in the package folder. This object is then used to govern runtime installation of the package.Checklist