Handle __repr__ of types#121
Merged
Merged
Conversation
Contributor
|
That's a great topic.... My 2 cents is that we should provide ways for users to decide what they want to do on 2 levels: the pyscript component level (with an attribute to |
Contributor
Author
|
I agree that configurability is probably our only way out of this problem. Let's open another issue about this and then merge this PR because this fix is independent of that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem here was that it was calling
type.__repr__which is missing the self argument. Instead we should simply callrepr(type). There is however a secondary problem, which is that since we are rendering straight to the DOM the<and>in the type repr get taken as an HTML tag and we still don't get any output. We will have to consider whether to always escape<and>when rendered into the DOM which would unfortunately mean that we cannot have strings be directly interpreted as HTML (e.g. breaking @pzwang's rick-roll demo in the PyCon keynote).Partially Fixes #120