Skip to content

output_manager.change should not be injected in the same code exec call  #657

@fpliger

Description

@fpliger

Checklist

  • I added a descriptive title
  • I searched for other issues and couldn't find a solution or duplication
  • I already searched in Google and didn't find any good information or help

What happened?

Currently, when we evaluate code, we inject output_manager.change to redirect output (stdout and stderr) to whatever the user specified. This is invasive and borks the content of a tag (<py-script> or <py-repl>). If we keep using that as ways to redirect output after implementing #622 we should at very least make sure it's not done in the same call and the function that returns a tag code, returns the original content.

What browsers are you seeing the problem on? (if applicable)

No response

Console info

No response

Additional Context

As part of the redesign of output vs display, we should fix the current experience. Reference: #622

For instance, affected code in repl

Metadata

Metadata

Assignees

Labels

sprintissue has been pulled into current sprint and is actively being worked ontype: bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

Status
Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions