Refactor and simplify MultivariateNormal distribution#693
Merged
neerajprad merged 5 commits intodevfrom Jan 23, 2018
Merged
Conversation
Member
|
failing tests though: |
This was referenced Jan 20, 2018
neerajprad
approved these changes
Jan 23, 2018
Member
neerajprad
left a comment
There was a problem hiding this comment.
Thanks for moving this into torch.distributions!
Member
|
@fritzo My GPRegression tutorial runs fine with this pull request. However, for a general case (when I use other likelihoods such as Bernoulli for GPClassification), Here is a simple script to replicate the problem Of course, the problem is more related to "how to deal with such RuntimeError", rather than this implementation of MultivariateNormal. |
Member
|
I think that it is better to raise an issue to discuss, rather than comment here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors and simplifies Pyro's
MultivariateNormaldistribution into a PyTorch-styleTorchMultivariateNormaldistribution plus a wrapper. This makes it easy to swap in a PyTorchMultivariateNormalas soon as it is available (as soon as probtorch/pytorch#52 is merged).This PR is needed to support @fehiepsi 's Gaussian Process tutorial #650 as Pyro migrates to PyTorch distributions.