Remove Pyro distributions migrated to PyTorch#684
Merged
fritzo merged 3 commits intopyro-ppl:devfrom Jan 17, 2018
Merged
Conversation
Member
|
this only removes the ones that have already been migrated correct? so we shouldnt be losing support for any existing distributions in this PR? |
Member
Author
That's right, not yet. :) What changes with this PR is that you need to build PyTorch master to be able to use Pyro's |
Member
Author
|
There is some travis CI slowdown, so it might take a while for the tests to start running. |
fritzo
previously approved these changes
Jan 17, 2018
10 tasks
Member
Author
|
Should be good to merge once tests pass. |
fritzo
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #638
This simply removes all the distributions that are already migrated to PyTorch. In subsequent PRs, we will rename the method names to align with
torch.distributions, and finally change the batch semantics and remove/update most of our existing test suite.