Adding docker support for pyro#648
Merged
jpchen merged 1 commit intopyro-ppl:devfrom Dec 23, 2017
Merged
Conversation
fritzo
approved these changes
Dec 22, 2017
Member
fritzo
left a comment
There was a problem hiding this comment.
Looks good, though I'm a docker novice.
Ready to merge?
Member
Author
I did a bunch of refactoring, so running a few quick tests. We should be good to merge after that. |
Member
Author
|
@fritzo - Thanks for reviewing. We can merge this pending @jpchen's approval. @rohitsingh0812, @OptimusLime - Please feel free to use / modify this for your use case, and let me know what can be improved. |
Member
|
will test cpu please hold off on merging until then, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds docker support for Pyro. This makes it simple to build Pyro over PyTorch using different configurations:
The Makefile has some common recipes to specify how to build the image. The documentation on building docker images and running them is in the readme. It also makes it easy to run notebook or ipython terminal using the built image. To handle data sharing between the container and the user's host system, we use the same uid/guid while building the image and have a shared workspace that can be configured from the Makefile. This is to make it easy to share data / view results, etc.
Tested locally using different configurations. Since I have refactored this quite a bit, I will continue to test that things are working before getting this merged.
TODO:
While building PyTorch from source using CUDA 9, we get a few intermediate errors even though the build is finally successful, and functional. This still needs a bit more investigation.
Fixes #195