Deprecate Categorical vs argument#647
Merged
neerajprad merged 1 commit intodevfrom Dec 21, 2017
Merged
Conversation
neerajprad
reviewed
Dec 21, 2017
| self.vs = self._process_data(vs) | ||
| self.log_pdf_mask = log_pdf_mask | ||
| if vs is not None: | ||
| warnings.warn('Categorical vs argument is deprecated', UserWarning) |
Member
There was a problem hiding this comment.
Are there existing examples/tutorials that use this argument currently? If not, we might as well just remove it on dev, as it will be removed by the next release.
Member
Author
There was a problem hiding this comment.
I believe vs is not used in any examples or tutorials. I looked into removing vs code but that turned out to be more work than adding a simple warning 😄
Member
There was a problem hiding this comment.
Looks good! We can definitely get this merged as is, and remove it completely along with the tests soon.
Member
Author
|
@neerajprad ready to merge |
neerajprad
approved these changes
Dec 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #646
Blocking #606
This deprecates the
vsargument toCategorical:vsfrom tests (so we can swap intorch.distributions.Categorical)UserWarningindicating thatvsis deprecated. (In generalUserWarnings are preferred overDeprecationWarnings because Python 2.7 silencesDeprecationWarningby default whereas Python 3.x does not silence them).Note that the implementation has been left in place. We will remove the old implementation when moving to PyTorch distributions.