Skip to content

Use @copy_docs_from on all existing distributions#642

Merged
neerajprad merged 1 commit intodevfrom
copy-docs-from
Dec 21, 2017
Merged

Use @copy_docs_from on all existing distributions#642
neerajprad merged 1 commit intodevfrom
copy-docs-from

Conversation

@fritzo
Copy link
Copy Markdown
Member

@fritzo fritzo commented Dec 21, 2017

This simplifies our task of migrating docs from pyro.distributions.* to pyro.distribution.torch.*

Tested

Ran make docs and verified that they look good.

Copy link
Copy Markdown
Member

@neerajprad neerajprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

@jpchen - could you update the documentation for the dev branch once this is merged?

@neerajprad neerajprad merged commit d751c45 into dev Dec 21, 2017
@jpchen
Copy link
Copy Markdown
Member

jpchen commented Dec 21, 2017

@neerajprad right now our docs only has one version ie release, which is also hardcoded in the sphinx config... i dont think we ever made that dynamic before launch. do you know the extension webppl uses to suppor multiple versions?

@neerajprad
Copy link
Copy Markdown
Member

@jpchen - I don't think we need any special extensions. The read the docs theme supports two versions - a stable one and the latest one (https://docs.readthedocs.io/en/latest/versions.html), but we may need to change our default branch to dev. We can try it out tomorrow and see if this works. We also need this for the tutorials, which I am guessing should be the same.

@fritzo fritzo deleted the copy-docs-from branch January 5, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants