Disallow instance override of .reparameterized property#640
Merged
neerajprad merged 2 commits intodevfrom Dec 20, 2017
Merged
Conversation
jpchen
reviewed
Dec 20, 2017
| reparameterized = False | ||
|
|
||
|
|
||
| nonreparameterized_normal = RandomPrimitive(NonreparameterizedNormal) |
Member
There was a problem hiding this comment.
why do you need this? cant you set the class attribute directly in the tests in your conditional?
Member
Author
There was a problem hiding this comment.
Mock.patching would not work in this case. Some tests.require both reparam and nonreparam versions of normal, and the attribute is examined out-of-order deep inside TraceGraph_ELBO after tracing the model and guide.
Member
There was a problem hiding this comment.
Once all our distributions are migrated, are we planning to use this as an alias for has_rsample?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631
This removes plumbing that allows Distribution instances to override the class-level
.reparameterizedproperty. Removing this plumbing simplifies our migration to torch.distributions. This plumbing was only used in tests; to provide the non-reparameterized Normal distribution provided by that override, this PR introduces afakes.NonreparameterizedNormaldistribution that is exposed only in tests/.