Replace unittest assertions with modern assertions#625
Merged
neerajprad merged 2 commits intodevfrom Dec 13, 2017
Merged
Conversation
eb8680
previously approved these changes
Dec 13, 2017
Member
eb8680
left a comment
There was a problem hiding this comment.
LGTM, looking forward to removing unittest dependencies entirely
neerajprad
approved these changes
Dec 13, 2017
Member
neerajprad
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@OptimusLime noticed that Pyro's tests mix old-style unittest assertions with new-style pytest assertions and the nicer
assert_equal()helper. This PR cleans up all of our tests to reduce use of unittest.Why?
Pytest provides better printing of error messages and a cleaner syntax for assertions, compared with unittest. Arguably pytest tests also require less boilerplate.