Fix ruff version to 0.3.4 in order to overcome issue with version 0.3.5.#3354
Merged
fritzo merged 1 commit intopyro-ppl:devfrom Apr 5, 2024
Merged
Conversation
Contributor
BenZickel
commented
Apr 5, 2024
- Linting with ruff version 0.3.5 fails as can be seen here.
- The failure is due to ruff version 0.3.5 not respecting this directive.
- The problem does not occur with ruff version 0.3.4.
fritzo
approved these changes
Apr 5, 2024
Member
fritzo
left a comment
There was a problem hiding this comment.
Thanks @BenZickel! Do you have any idea how to get ruff>=0.3.5 to respect __all__?
Contributor
Author
|
Hi @fritzo! I think the issue is that ruff 0.3.5 is not respecting the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.