Skip to content

[Do not merge] Run tests in parallel#116

Closed
neerajprad wants to merge 1 commit intopyro-ppl:devfrom
neerajprad:issue_114_parallelize_tests
Closed

[Do not merge] Run tests in parallel#116
neerajprad wants to merge 1 commit intopyro-ppl:devfrom
neerajprad:issue_114_parallelize_tests

Conversation

@neerajprad
Copy link
Copy Markdown
Member

Testing parallel test runs using pytest-xdist.

Comment thread .travis.yml Outdated

script:
- PYTHONPATH=$PWD:$PYTHONPATH pytest -s --cov=pyro
- PYTHONPATH=$PWD:$PYTHONPATH pytest -s -n auto --cov=pyro
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many cores are available on travis? When I've done this in the past there were only a couple cores available, and they were probably just hyperthreads of a single core. An alternate way to parallelize is via a matrix, as we've done in Nimble.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to check that, and you are right that there are only 2 cores, so this won't be useful. Using a matrix will be a much better solution - that way, we can separate out the slow running integration tests too. Will check out Nimble, and change our config to use matrix. Thanks for the link!

@neerajprad
Copy link
Copy Markdown
Member Author

Let us prioritize #115 and #117 first. Given that we have only two cores available in the workers and the test time distribution is highly skewed with a few tests taking most of the time (see #114), this kind of parallelization is unlikely to give us any significant speed up.

@neerajprad
Copy link
Copy Markdown
Member Author

Abandoning this PR; we do not seem to get any substantial speed up by using both the cores. We will use the build stages feature to parallelize tests as needed.

@neerajprad neerajprad closed this Sep 15, 2017
@neerajprad neerajprad deleted the issue_114_parallelize_tests branch September 15, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants