bunch of improvements for clipboard#3206
Conversation
- handle esc for rectangle select - paste selection with cat flag - autoselect when using selectfromlist - smartbutton init add return (still broken, but at least semantically correct)
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
There was a problem hiding this comment.
Pull request overview
This PR addresses several usability and correctness issues in the Match History Clipboard tool within the pyRevitTools extension, focusing on safer parameter retrieval, improved selection/paste behavior, and better UI state updates.
Changes:
- Updates
safe_get_parameterto better handle BuiltIn vs shared/project parameters and add exception safety. - Improves paste workflows: handle ESC during rectangle selection and apply category filtering to “paste from selection”.
- Auto-selects newly added history items after using the parameter picker, and updates smartbutton init semantics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit1.stack/Match.splitpushbutton/Match History Clipboard.smartbutton/script.py |
Adjusts smartbutton initialization behavior (icon init logic commented out; returns True). |
extensions/pyRevitTools.extension/lib/match/panel.py |
Auto-selects newly added history items after select_parameters and refreshes UI enabled-state. |
extensions/pyRevitTools.extension/lib/match/match_utils.py |
Refines parameter lookup, adds ESC handling for rectangle pick, and applies category filtering for paste-from-selection. |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip |
|
📦 New public release are available for 6.2.0.26090+1754 |
Description
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request: