fix(ribbon): tab downgrade, combobox crash, keys/values return, tooltip error msg#3202
Merged
jmcouffin merged 5 commits intopyrevitlabs:developfrom Mar 31, 2026
Merged
Conversation
Contributor
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets robustness issues in pyRevit’s ribbon UI wrappers to prevent pyRevit tabs/panels from breaking (or being misclassified as native) due to specific ribbon item edge cases.
Changes:
- Fix
GenericPyRevitUIContainer.keys()/.values()to actually return lists. - Fix deferred tooltip-image exception to reference
tooltip_image(nottooltip_video). - Extend panel item wrapping to recognize
UI.ComboBoxand skip unknown item types instead of raising.
jmcouffin
approved these changes
Mar 31, 2026
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip |
Contributor
|
📦 New public release are available for 6.2.0.26090+1754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_PyRevitRibbonTab.__init__: replace bareraisein panel-loadingexceptwithmlogger.debug— prevents pyrevit tabs from being silently downgraded toRevitNativeRibbonTabwhen any panel item fails to load_PyRevitRibbonPanel.__init__: addUI.ComboBoxbranch to item-type dispatcher; demote unknown types fromraisetomlogger.debugto prevent a single unrecognised item from killing the whole tabGenericPyRevitUIContainer.keys/values: add missingreturnstatements_PyRevitRibbonButton.process_deferred: fix wrong variable (tooltip_video→tooltip_image) in deferred tooltip-image error messageChecklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Does this affect the new c# launcher? Does it need a similiar fix?