Skip to content

Make use of improved lib in new match clipboard pane#3197

Merged
jmcouffin merged 5 commits intopyrevitlabs:developfrom
Wurschdhaud:make-use-of-improved-lib
Mar 29, 2026
Merged

Make use of improved lib in new match clipboard pane#3197
jmcouffin merged 5 commits intopyrevitlabs:developfrom
Wurschdhaud:make-use-of-improved-lib

Conversation

@Wurschdhaud
Copy link
Copy Markdown
Contributor

Description

make use of #3177 to

  • simplify smartbutton (init still broken. no idea why.)
  • multilanguage support
  • icons for buttons

Checklist

Before submitting your pull request, ensure the following requirements are met:

  • Code follows the PEP 8 style guide.
  • Code has been formatted with Black using the command:
    pipenv run black {source_file_or_directory}
  • Changes are tested and verified to work as expected.

@devloai
Copy link
Copy Markdown
Contributor

devloai bot commented Mar 27, 2026

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

@jmcouffin jmcouffin requested a review from Copilot March 27, 2026 19:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Match History Clipboard pane to leverage the improved docking-panel helpers, add localization for UI strings, and introduce iconized button layouts.

Changes:

  • Replaced manual DockablePane GUID handling with pyrevit.forms dockable panel helpers in the smartbutton script.
  • Switched hard-coded UI strings to localized DynamicResource keys and added per-locale resource dictionaries.
  • Updated button content to include icons + text for improved UI clarity.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

File Description
extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit1.stack/Match.splitpushbutton/Match History Clipboard.smartbutton/script.py Migrates dockable panel toggling logic to new helper APIs and updates smartbutton icon handling.
extensions/pyRevitTools.extension/lib/match/clipboard_pane_ui.xaml Replaces literal strings with localized resources and updates buttons to icon+text layouts.
extensions/pyRevitTools.extension/lib/match/clipboard_pane_ui.ResourceDictionary.*.xaml Adds localized string resources (en, de, es, fr, pt_br, ru, chinese_s) used by the pane XAML.

@jmcouffin jmcouffin merged commit 5324ca9 into pyrevitlabs:develop Mar 29, 2026
@Wurschdhaud Wurschdhaud deleted the make-use-of-improved-lib branch March 29, 2026 13:17
@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26088+1318-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip

@github-actions
Copy link
Copy Markdown
Contributor

📦 New public release are available for 6.2.0.26090+1754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants