fix: resolve C# loader regressions (#3108, #3107, #3140, version-info) by tay0thman · Pull Request #3188 · pyrevitlabs/pyRevit

tay0thman · 2026-03-22T11:26:03Z

resolve C# loader regressions

Description

[Bug]: Startup scripts fail in 6.1 #3108: Restore multi-pass loop in SessionManagerService.LoadSession() so all assemblies load before any startup script runs. Fixes cross-extension imports in startup scripts.
[Bug]: Extension folder can't start with a number #3107: Prefix underscore when SanitizeClassName() produces a name starting with a digit (invalid C# identifier). Applied in ExtensionParser, CommandTypeGenerator, ButtonBuilderBase, StackBuilder.
[Bug]:ERROR [pyrevit.loader.sessionmgr] #3140: Add HashSet dedup guard in CommandTypeGenerator.GenerateExtensionCode() to skip duplicate class names instead of emitting CS0101 Roslyn errors.
Version info: Pass revitYear through ExtensionManagerService to ExtensionParser.ParseInstalledExtensions() so min/max version filtering works correctly. Previously defaulted to 0 (unknown).

Checklist

Before submitting your pull request, ensure the following requirements are met:

[OK ] Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves [Bug]: Startup scripts fail in 6.1 #3108: , [Bug]: Extension folder can't start with a number #3107, [Bug]:ERROR [pyrevit.loader.sessionmgr] #3140:

Additional Notes

Tested on Revit 2026 (netcore) and 2024(netfx)

Thank you for contributing to pyRevit! 🎉

devloai · 2026-03-22T11:26:08Z

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot

Pull request overview

This PR addresses several regressions in the C# loader path of pyRevit’s Revit add-in, aiming to restore legacy loader behavior for startup ordering, identifier generation, duplicate type handling, and Revit version filtering.

Changes:

Reintroduces multi-pass session loading so all extension assemblies load before any startup scripts execute.
Hardens identifier/class-name sanitization (including leading-digit handling) across parser, generators, and UI builders.
Adds Revit-year propagation into extension parsing for min/max version gating, and introduces a duplicate class-name guard in Roslyn code generation.

Reviewed changes

Copilot reviewed 10 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
dev/pyRevitLoader/pyRevitExtensionParserTester/ParsedBundleTests.cs	Updates test sanitizer to match production leading-digit behavior.
dev/pyRevitLoader/pyRevitExtensionParserTester/ComponentValidationTests.cs	Tightens UniqueId validity rules in tests (disallow leading digits).
dev/pyRevitLoader/pyRevitExtensionParser/ParsedExtension.cs	Adds `RocketModeCompatible` flag on parsed extensions.
dev/pyRevitLoader/pyRevitExtensionParser/ExtensionParser.cs	Adds Revit version compatibility checks and passes `revitYear` through parsing; updates UniqueId sanitization logic.
dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/SessionManagerService.cs	Restores multi-pass load order: build/load assemblies → run startup scripts → build UI.
dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/Buttons/ButtonBuilderBase.cs	Ensures generated command class identifiers never start with a digit.
dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/Builders/StackBuilder.cs	Aligns stack builder class-name sanitization with leading-digit fix.
dev/pyRevitLoader/pyRevitAssemblyBuilder/SessionManager/ServiceFactory.cs	Parses/passes Revit year into ExtensionManagerService for version filtering.
dev/pyRevitLoader/pyRevitAssemblyBuilder/SessionManager/ExtensionManagerService.cs	Uses `revitYear` when parsing installed extensions (cached).
dev/pyRevitLoader/pyRevitAssemblyBuilder/AssemblyMaker/CommandTypeGenerator.cs	Adds duplicate class-name guard; updates engine-config generation behavior and identifier sanitization.

dev/pyRevitLoader/pyRevitAssemblyBuilder/AssemblyMaker/CommandTypeGenerator.cs

dev/pyRevitLoader/pyRevitExtensionParser/ExtensionParser.cs

Addresses Copilot review: avoid misleading 'skipped' log messages and log spam when Revit version is unknown (revitYear <= 0).

tay0thman · 2026-03-23T06:37:23Z

@devloai If you are available , review my responses to copilot AI

devloai · 2026-03-23T06:37:29Z

Unable to trigger custom agent "PR Assistant". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot

Pull request overview

Copilot reviewed 10 out of 26 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

dev/pyRevitLoader/pyRevitExtensionParser/ParsedExtension.cs:23

ParsedExtension now declares RocketModeCompatible twice (one auto-property at line 19 and another at lines 21-27 with default initializer). This will not compile due to duplicate member names. Remove one of the properties (and keep the XML doc + default initializer on the remaining one if needed).

        public bool RocketModeCompatible { get; set; }

        /// <summary>
        /// Gets or sets whether this extension is compatible with rocket mode.
        /// When rocket mode is enabled and the extension is compatible, the engine

dev/pyRevitLoader/pyRevitExtensionParser/ExtensionParser.cs

dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/SessionManagerService.cs

…ptions - Remove duplicate RocketModeCompatible declaration (already in develop) - Log ex.ToString() instead of ex.Message in SessionManagerService catch blocks

tay0thman · 2026-03-23T16:58:11Z

@jmcouffin can you request another round of review by copilot? I think I covered all of its comments but just to make sure, I tested the DLLs locally and looks good here.

Copilot

Pull request overview

Copilot reviewed 9 out of 25 changed files in this pull request and generated 2 comments.

dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/SessionManagerService.cs

dev/pyRevitLoader/pyRevitAssemblyBuilder/SessionManager/ExtensionManagerService.cs

…tatic

jmcouffin · 2026-03-24T21:27:20Z

@romangolev can you take a look?

romangolev · 2026-03-27T19:23:06Z

@tay0thman @jmcouffin works well in Revit 2025 ^_^

jmcouffin · 2026-03-27T20:01:25Z

@tay0thman blessing from Roman!
Bravo!

github-actions · 2026-03-27T20:15:08Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26086+2004-wip

github-actions · 2026-03-29T13:30:24Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26088+1318-wip

github-actions · 2026-03-30T12:42:21Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip

github-actions · 2026-03-31T06:00:01Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip

github-actions · 2026-03-31T15:44:25Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip

github-actions · 2026-03-31T15:47:15Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip

github-actions · 2026-03-31T15:51:32Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T15:51:35Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T16:07:20Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip

github-actions · 2026-03-31T16:13:45Z

📦 New public release are available for 6.2.0.26090+1754

tay0thman requested review from jmcouffin and romangolev March 22, 2026 11:26

jmcouffin requested a review from Copilot March 22, 2026 11:38

tay0thman force-pushed the fix/csharp-loader-regressions branch from db0b7a6 to 0e8830b Compare March 22, 2026 11:38

Copilot started reviewing on behalf of jmcouffin March 22, 2026 11:38 View session

fix: resolve C# loader regressions (#3108, #3107, #3140, version-info)

60982e0

tay0thman force-pushed the fix/csharp-loader-regressions branch from 0e8830b to 60982e0 Compare March 22, 2026 11:40

Copilot AI reviewed Mar 22, 2026

View reviewed changes

tay0thman added 2 commits March 22, 2026 04:53

fix: move revitYear early-exit to top of IsRevitVersionCompatible()

63c43e7

Addresses Copilot review: avoid misleading 'skipped' log messages and log spam when Revit version is unknown (revitYear <= 0).

Merge origin/develop into fix/csharp-loader-regressions

d55451a

jmcouffin requested a review from Copilot March 23, 2026 06:54

Copilot started reviewing on behalf of jmcouffin March 23, 2026 06:55 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

fix: remove duplicate RocketModeCompatible property and log full exce…

4943c61

…ptions - Remove duplicate RocketModeCompatible declaration (already in develop) - Log ex.ToString() instead of ex.Message in SessionManagerService catch blocks

jmcouffin requested a review from Copilot March 23, 2026 17:28

Copilot started reviewing on behalf of jmcouffin March 23, 2026 17:29 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/SessionManagerService.cs Show resolved Hide resolved

dev/pyRevitLoader/pyRevitAssemblyBuilder/SessionManager/ExtensionManagerService.cs Outdated Show resolved Hide resolved

fix: address Copilot review - remaining ex.Message and unused using s…

9157d71

…tatic

jmcouffin self-assigned this Mar 24, 2026

romangolev approved these changes Mar 27, 2026

View reviewed changes

jmcouffin merged commit 69775c5 into develop Mar 27, 2026

jmcouffin deleted the fix/csharp-loader-regressions branch March 27, 2026 20:01

Uh oh!

Conversation

tay0thman commented Mar 22, 2026

resolve C# loader regressions

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot commented Mar 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay0thman commented Mar 23, 2026

Uh oh!

devloai bot commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tay0thman commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

jmcouffin commented Mar 24, 2026

Uh oh!

romangolev commented Mar 27, 2026

Uh oh!

jmcouffin commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 29, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants