Allowed for -script, _script and .script.py file extensions#3131
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to restore support for multiple script file naming conventions that were supported in pyRevit 4.x but broke in later versions. The change aims to allow script files within bundles to be named with various patterns ending in "script", specifically: script.*, -script.*, .script.*, and _script.*.
Changes:
- Added a filter in ExtensionParser.cs to validate that discovered script files match one of four valid ending patterns: "script", "_script", "-script", or ".script"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@sweco-beb283 For all changes to C#, for next time, please compile the necessary dll and make a specific commit once you feel the PR is good to go/be reviewed with the title:
This is both a convenience for reviewer and for people using the Clones functionality of the CLI |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2054-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2111-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2115-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2121-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2123-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26057+1645-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26057+2022-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26058+1619-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1027-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1126-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1139-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1233-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1244-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1357-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1403-wip |
|
@jmcouffin Ooh, so you're saying the built binaries are included in git for a reason? Gotcha, will do. |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26069+2130-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26071+0706-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26073+1714-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26073+2220-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26074+1648-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26076+0001-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26077+2319-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26079+2333-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26080+1314-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2031-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2042-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2048-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2106-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2130-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26086+2004-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26088+1318-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip |
|
📦 New public release are available for 6.2.0.26090+1754 |
Allowed for -script, _script and .script.py file extensions
Description
This is more of a reinstation of an old convention if any, but I ran into an issue where my old scripts suddenly didn't work anymore. Figures it was the naming convention.
Up to PyRevit 4.X a script file inside a bundle could be called anything, as long as it ended with the word
script.Since 6 (maybe even 5) this is no longer the case, and I wanted to bring that back.
Specifically the following file name endings will be picked up as valid script files:
script.*-script.*.script.*_script.*Checklist
pipenv run black {source_file_or_directory}Related Issues
None
Additional Notes
None