Fix StaticResource crash in forms loader by Wurschdhaud · Pull Request #3123 · pyrevitlabs/pyRevit

Wurschdhaud · 2026-02-21T17:46:59Z

Description

Problem

Some tools (e.g. Print Sheets) failed to load with:

Provide value on 'System.Windows.StaticResourceExtension' threw an exception.

This occurred because pending resource dictionaries were merged after wpf.LoadComponent().

Since StaticResource is resolved at XAML load time, any referenced resources must already be present in the window's resource tree. If the merge happens later, WPF fails during parsing.

Solution

Merge _pending_resource_merge before calling wpf.LoadComponent() so that all required resources are available during XAML parsing.

if getattr(self, '_pending_resource_merge', None):
    self.merge_resource_dict(self._pending_resource_merge)
    self._pending_resource_merge = None

wpf.LoadComponent(self, xaml)

Result

Fixes StaticResourceExtension exceptions

Restores correct loading of tools relying on merged resource dictionaries

Aligns resource initialization with WPF load-time requirements

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves [Bug]: Print Function Doesn't Work #3113

…ticresources

devloai · 2026-02-21T17:47:02Z

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

WemyssJ · 2026-02-23T12:42:47Z

Tested - this fixes the issue for me!

Removed comment about merging ResourceDictionary files after LoadComponent.

github-actions · 2026-02-23T16:55:02Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26054+1644-wip

github-actions · 2026-02-24T20:51:17Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2040-wip

github-actions · 2026-02-24T21:05:23Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2054-wip

github-actions · 2026-02-24T21:22:30Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2111-wip

github-actions · 2026-02-24T21:26:13Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2115-wip

github-actions · 2026-02-24T21:32:27Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2121-wip

github-actions · 2026-02-24T21:34:41Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2123-wip

github-actions · 2026-02-26T16:56:38Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26057+1645-wip

github-actions · 2026-02-26T20:33:50Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26057+2022-wip

github-actions · 2026-02-27T16:29:31Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26058+1619-wip

github-actions · 2026-03-02T10:38:21Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1027-wip

github-actions · 2026-03-02T11:36:25Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1126-wip

github-actions · 2026-03-02T11:52:09Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1139-wip

github-actions · 2026-03-02T12:43:02Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1233-wip

github-actions · 2026-03-02T12:57:06Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1244-wip

github-actions · 2026-03-02T14:08:28Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1357-wip

github-actions · 2026-03-02T14:14:20Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1403-wip

github-actions · 2026-03-10T21:43:15Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26069+2130-wip

github-actions · 2026-03-12T07:17:43Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26071+0706-wip

github-actions · 2026-03-14T17:24:48Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26073+1714-wip

github-actions · 2026-03-14T22:30:02Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26073+2220-wip

github-actions · 2026-03-15T16:58:32Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26074+1648-wip

github-actions · 2026-03-17T00:12:46Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26076+0001-wip

github-actions · 2026-03-18T23:30:05Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26077+2319-wip

github-actions · 2026-03-20T23:44:55Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26079+2333-wip

github-actions · 2026-03-21T13:30:26Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26080+1314-wip

github-actions · 2026-03-24T20:43:11Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2031-wip

github-actions · 2026-03-24T20:55:54Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2042-wip

github-actions · 2026-03-24T20:56:39Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2045-wip

github-actions · 2026-03-24T20:59:26Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2048-wip

github-actions · 2026-03-24T21:18:35Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2106-wip

github-actions · 2026-03-24T21:41:42Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2130-wip

github-actions · 2026-03-27T20:15:51Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26086+2004-wip

github-actions · 2026-03-29T13:31:07Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26088+1318-wip

github-actions · 2026-03-30T12:43:09Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip

github-actions · 2026-03-31T06:00:50Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip

github-actions · 2026-03-31T15:45:21Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip

github-actions · 2026-03-31T15:48:03Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip

github-actions · 2026-03-31T15:52:22Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T15:52:28Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip

github-actions · 2026-03-31T16:08:09Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip

github-actions · 2026-03-31T16:14:32Z

📦 New public release are available for 6.2.0.26090+1754

fix resource dic getting loaded after load component, failing for sta…

ddebc0a

…ticresources

jmcouffin requested a review from Copilot February 23, 2026 16:24

jmcouffin previously approved these changes Feb 23, 2026

View reviewed changes

Copilot started reviewing on behalf of jmcouffin February 23, 2026 16:25 View session

This comment was marked as outdated.

Sign in to view

Remove comment regarding ResourceDictionary merging

b1f321d

Removed comment about merging ResourceDictionary files after LoadComponent.

jmcouffin dismissed their stale review via b1f321d February 23, 2026 16:40

jmcouffin approved these changes Feb 23, 2026

View reviewed changes

jmcouffin merged commit 240e9e1 into pyrevitlabs:develop Feb 23, 2026

Wurschdhaud deleted the fix-3113 branch February 25, 2026 05:59

Uh oh!

Conversation

Wurschdhaud commented Feb 21, 2026

Description

Problem

Solution

Result

Checklist

Related Issues

Uh oh!

devloai bot commented Feb 21, 2026

Uh oh!

WemyssJ commented Feb 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 12, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

github-actions bot commented Mar 15, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!