fix: restore non-integer support in ReNumber tool#3120
fix: restore non-integer support in ReNumber tool#3120jmcouffin merged 1 commit intopyrevitlabs:developfrom
Conversation
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the ReNumber tool that broke support for non-integer starting numbers (letters like "A", "B", "C" for grids, and decimals). The bug was introduced when ProgressBar was added with int() casts that didn't account for non-integer inputs.
Changes:
- Added defensive try-except handling around ProgressBar updates in the renumbering loop
- Created a no-op progress bar stub (_NoOpPB) for non-integer starting numbers
- Added branching logic to use ProgressBar for integers and WarningBar with the stub for non-integers
...ns/pyRevitTools.extension/pyRevit.tab/Modify.panel/edit2.stack/ReNumber.pushbutton/script.py
Show resolved
Hide resolved
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26052+1303-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26052+1321-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26052+1323-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26052+1326-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26052+1330-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26054+1628-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26054+1644-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2040-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2054-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2111-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2115-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2121-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26055+2123-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26057+1645-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26057+2022-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26058+1619-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1027-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1126-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1139-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1233-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1244-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1357-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1403-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26069+2130-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26071+0706-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26073+1714-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26073+2220-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26074+1648-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26076+0001-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26077+2319-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26079+2333-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26080+1314-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2031-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2042-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2048-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2106-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26083+2130-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26086+2004-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26088+1318-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26089+1231-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+0549-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1533-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1536-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1540-wip |
|
📦 New work-in-progress (wip) builds are available for 6.1.0.26090+1556-wip |
|
📦 New public release are available for 6.2.0.26090+1754 |
Description
The introduction of ProgressBar added
int()casts on the starting number and index, breaking letter and decimal inputs (e.g. grids labelled A, B, C...).Fixes by branching on whether the starting value is integer-compatible: uses ProgressBar for integers, WarningBar + a no-op stub for everything else. No change to renumbering logic.
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request: